-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSDeepSimilarityQueryLogic implementation #2085
Conversation
Provides the ability to query an index of bucketized SSDeep ngrams.
Ultimately some of the code in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, everything looks pretty good. Just have a few comments/questions.
warehouse/query-core/src/main/java/datawave/query/tables/SSDeepSimilarityQueryLogic.java
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/tables/SSDeepSimilarityQueryLogic.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/tables/SSDeepSimilarityQueryLogic.java
Outdated
Show resolved
Hide resolved
...se/query-core/src/main/java/datawave/query/transformer/SSDeepSimilarityQueryTransformer.java
Outdated
Show resolved
Hide resolved
...se/query-core/src/main/java/datawave/query/transformer/SSDeepSimilarityQueryTransformer.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/test/java/datawave/query/SSDeepQueryTest.java
Outdated
Show resolved
Hide resolved
...uery-core/src/test/java/datawave/query/transformer/SSDeepSimilarityQueryTransformerTest.java
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/tables/SSDeepSimilarityQueryLogic.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions. Overall looks good o me.
...se/query-core/src/main/java/datawave/query/transformer/SSDeepSimilarityQueryTransformer.java
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/util/ssdeep/BucketAccumuloKeyGenerator.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/util/ssdeep/ChunkSizeEncoding.java
Outdated
Show resolved
Hide resolved
4de0652
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New commit changes look good and build successfully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes look good!
Provides the ability to query an index of bucketized SSDeep ngrams See: https://github.com/NationalSecurityAgency/datawave/wiki/SSDeep-In-Datawave
Provides the ability to query an index of bucketized SSDeep ngrams See: https://github.com/NationalSecurityAgency/datawave/wiki/SSDeep-In-Datawave
Provides the ability to query an index of bucketized SSDeep ngrams See: https://github.com/NationalSecurityAgency/datawave/wiki/SSDeep-In-Datawave
Provides the ability to query an index of bucketized SSDeep ngrams See: https://github.com/NationalSecurityAgency/datawave/wiki/SSDeep-In-Datawave
Provides the ability to query an index of bucketized SSDeep ngrams. Documentation will be added to the wiki at https://github.com/NationalSecurityAgency/datawave/wiki/SSDeep-In-Datawave