Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSDeepSimilarityQueryLogic implementation #2085

Merged
merged 8 commits into from
Oct 2, 2023

Conversation

drewfarris
Copy link
Collaborator

@drewfarris drewfarris commented Sep 11, 2023

Provides the ability to query an index of bucketized SSDeep ngrams. Documentation will be added to the wiki at https://github.com/NationalSecurityAgency/datawave/wiki/SSDeep-In-Datawave

Provides the ability to query an index of bucketized SSDeep ngrams.
@drewfarris drewfarris self-assigned this Sep 11, 2023
@drewfarris
Copy link
Collaborator Author

Ultimately some of the code in the utils.ssdeep package should be moved to core because it can be used for both ingest and query

Copy link
Collaborator

@jack-gitdev jack-gitdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, everything looks pretty good. Just have a few comments/questions.

jack-gitdev
jack-gitdev previously approved these changes Sep 21, 2023
MiguelRicardos
MiguelRicardos previously approved these changes Sep 27, 2023
Copy link
Collaborator

@MiguelRicardos MiguelRicardos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions. Overall looks good o me.

Copy link
Collaborator

@jack-gitdev jack-gitdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New commit changes look good and build successfully.

Copy link
Collaborator

@MiguelRicardos MiguelRicardos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good!

@drewfarris drewfarris merged commit 6770472 into integration Oct 2, 2023
hgklohr pushed a commit that referenced this pull request Oct 13, 2023
hgklohr pushed a commit that referenced this pull request Oct 18, 2023
hgklohr pushed a commit that referenced this pull request Oct 18, 2023
hgklohr pushed a commit that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants