Update SSDeepQueryTest to properly validate unit test results

NationalSecurityAgency · Sep 19, 2023 · 9c5120a · 9c5120a
1 parent f203f1c
commit 9c5120a
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 5 deletions.
diff --git a/...query-core/src/main/java/datawave/query/transformer/SSDeepSimilarityQueryTransformer.java b/...query-core/src/main/java/datawave/query/transformer/SSDeepSimilarityQueryTransformer.java
@@ -152,7 +152,7 @@ public Map.Entry<SSDeepHash,NGramTuple> transform(Map.Entry<Key,Value> input) th
         final NGramTuple c = new NGramTuple(chunkSize, ngram);
 
         // extract the matching ssdeep hash from the column qualifier
-        final String s = input.getKey().getColumnQualifier().toString();
+        final String s = k.getColumnQualifier().toString();
         try {
             final SSDeepHash h = SSDeepHash.parse(s);
             return new AbstractMap.SimpleImmutableEntry<>(h, c);

diff --git a/warehouse/query-core/src/test/java/datawave/query/SSDeepQueryTest.java b/warehouse/query-core/src/test/java/datawave/query/SSDeepQueryTest.java
@@ -2,9 +2,14 @@
 
 import static org.junit.Assert.fail;
 
+import java.util.ArrayList;
 import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
 import java.util.Iterator;
+import java.util.List;
 import java.util.Map;
+import java.util.Set;
 import java.util.UUID;
 import java.util.stream.Stream;
 
@@ -45,8 +50,11 @@
 import datawave.webservice.common.connection.AccumuloConnectionFactory;
 import datawave.webservice.query.QueryImpl;
 import datawave.webservice.query.result.event.DefaultResponseObjectFactory;
+import datawave.webservice.query.result.event.EventBase;
+import datawave.webservice.query.result.event.FieldBase;
 import datawave.webservice.query.runner.RunningQuery;
 import datawave.webservice.result.EventQueryResponseBase;
+import it.unimi.dsi.fastutil.Hash;
 
 public class SSDeepQueryTest {
 
@@ -154,11 +162,30 @@ public void setUpQuery() {
     @Test
     public void testSingleQuery() throws Exception {
         String query = "CHECKSUM_SSDEEP:" + TEST_SSDEEPS[2];
-        runSSDeepQuery(query);
-        Assert.assertTrue(true);
+        EventQueryResponseBase response = runSSDeepQuery(query);
+        List<EventBase> events = response.getEvents();
+        int eventCount = events.size();
+
+        Map<String,String> observedFields = new HashMap<>();
+        if (eventCount > 0) {
+            for (EventBase e : events) {
+                List<FieldBase> fields = e.getFields();
+                for (FieldBase f : fields) {
+                    observedFields.put(f.getName(), f.getValueString());
+                }
+            }
+        }
+
+        Assert.assertFalse("Observed fields was unexpectedly empty", observedFields.isEmpty());
+        Assert.assertEquals("65.0", observedFields.remove("MATCH_SCORE"));
+        Assert.assertEquals("1", observedFields.remove("MATCH_RANK"));
+        Assert.assertEquals("3072:02irbxzGAFYDMxud7fKg3dXVmbOn5u46Kjnz/G8VYrs123D6pIJLIOSP:02MKlWQ7Sg3d4bO968rm7JO", observedFields.remove("QUERY_SSDEEP"));
+        Assert.assertEquals("3072:02irbxzGAFYDMxud7fKg3dXVmbOn5u46Kjnz/G8VYrs123D6pIJLIOSP:02MKlWQ7Sg3d4bO968rm7JO", observedFields.remove("MATCHING_SSDEEP"));
+        Assert.assertTrue("Observed unexpected field(s): " + observedFields, observedFields.isEmpty());
+        Assert.assertEquals(1, eventCount);
     }
 
-    public void runSSDeepQuery(String query) throws Exception {
+    public EventQueryResponseBase runSSDeepQuery(String query) throws Exception {
         QueryImpl q = new QueryImpl();
         q.setQuery(query);
         q.setId(UUID.randomUUID());
@@ -171,6 +198,6 @@ public void runSSDeepQuery(String query) throws Exception {
         SSDeepSimilarityQueryTransformer transformer = (SSDeepSimilarityQueryTransformer) transformIterator.getTransformer();
         EventQueryResponseBase response = (EventQueryResponseBase) transformer.createResponse(runner.next());
 
-        System.out.println(response);
+        return response;
     }
 }