Array metadata replacement #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be_quiet() routine for reduced console output
…rrays have zero size
|
Yes, it seems like |
Yes, this was part of an attempt to avoid SWIG/python problems associated with arrays of |
Closed
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* added C++ and python routines for fetching array metadata; also added be_quiet() routine for reduced console output * updates * updates * updates * updates * updates * updates * revised 'python/meep.i:_get_dft_array()' to avoid crashing when dft_arrays have zero size * updates * updates * updates * updates * get_array_metadata * updates * updates * updates * updates * updates * updates * get_array_metadata * updates * updates * updates * updates * updates * Use direction array for get_array_slice_dimensions * Clean up non-essential changes * Add missing section from 652 * Allow direction array as argument to get_array_slice_dimensions * Pass params by reference in compute_boundary_weights * Remove unused typemaps * Don't do direction subtraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces and closes #552. I made the following changes:
fields::get_array_slice_dimensionsto take adirection[3]instead ofint[3]by writing a wrapper for SWIG called_get_array_slice_dimensions.h5testby passingis,ie, andwherecby reference tocompute_boundary_weights.The only thing I'm unsure of is why we subtract the
Xdirection on line 391 inarray_slice.cpp:Why is that necessary? Was it just for casting to an
intwhendirswasint[3]?@stevengj @oskooi @HomerReid