Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cutoff parameter of ContinuousSource class to slowness #2499

Merged
merged 2 commits into from
May 4, 2023

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented May 3, 2023

Fixes a bug in the ContinuousSource class in which the cutoff parameter (which does not exist for this time profile) should have been named slowness.

Thanks to @jball1982 for the bug report in #701 (comment).

@codecov-commenter
Copy link

Codecov Report

Merging #2499 (4b84a46) into master (d0d81bb) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #2499   +/-   ##
=======================================
  Coverage   73.82%   73.82%           
=======================================
  Files          17       17           
  Lines        5269     5269           
=======================================
  Hits         3890     3890           
  Misses       1379     1379           
Impacted Files Coverage Δ
python/source.py 94.33% <100.00%> (ø)

@oskooi oskooi merged commit 79e8d17 into NanoComp:master May 4, 2023
@oskooi oskooi deleted the cwsrc_slowness branch May 4, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants