Bug fixes for GaussianBeam2DSource #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A detailed description of this first commit is found under this comment here. |
Codecov Report
@@ Coverage Diff @@
## master #2363 +/- ##
==========================================
- Coverage 72.55% 72.49% -0.06%
==========================================
Files 17 17
Lines 5156 5145 -11
==========================================
- Hits 3741 3730 -11
Misses 1415 1415
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request begins the bug fixes for GaussianBeam2DSource as described under issue #2356 .
Before merging, there is one last fix still required: When the material index is too high, and the beam waist becomes much smaller than the effective wavelength in the material, the overflows occur when passing values into the complex Hankel functions.
After finding these bugs, it might also be useful to add more test cases such as different materials, wavelengths, etc.