Add two unit tests for adjoint gradients related to source and monitor bandwidths #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by factor of two to ten in almost all tests
oskooi
force-pushed
the
adjgrad_bandwidth
branch
from
2086ebf to
7619adf
Compare
|
By reducing the source bandwidth by a factor of four, it is possible to then lower the minimum tolerance used to compare the adjoint gradient against the finite-difference approximation by a factor of two to ten. A tighter check makes for a stronger test. Separately, I have added a one-line docstring to all of the tests which summarizes what the test is doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2307.