Add more type hints and regenerate Markdown pages from docstrings #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2206 +/- ##
=======================================
Coverage 73.24% 73.24%
=======================================
Files 17 17
Lines 4897 4897
=======================================
Hits 3587 3587
Misses 1310 1310
|
stevengj
reviewed
Aug 25, 2022
| @@ -3048,7 +3059,7 @@ def _display_energy(self, name, func, energys): | |||
| zip(freqs, *[func(f) for f in energys]), | |||
| ) | |||
|
|
|||
| def display_electric_energy(self, *energys): | |||
| def display_electric_energy(self, *energys: List[DftEnergy]): | |||
There was a problem hiding this comment.
Why is energies misspelled here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes the precommit error described in #2203 (comment).