Damping #1804
Merged
Damping #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 19, 2021 19:57
Codecov Report
@@ Coverage Diff @@
## master #1804 +/- ##
=======================================
Coverage 73.90% 73.91%
=======================================
Files 17 17
Lines 4913 4914 +1
=======================================
+ Hits 3631 3632 +1
Misses 1282 1282
|
|
(You should add "Closes #1788" to the start of your PR so it links and closes when merged.) |
stevengj
reviewed
Oct 27, 2021
src/meepgeom.cpp
Outdated
| if (get_cnd(c, &((material_type) geometry.items[i].material)->medium_1) || | ||
| get_cnd(c, &((material_type) geometry.items[i].material)->medium_2) || | ||
| (((material_type) geometry.items[i].material)->damping != 0)) return true; | ||
| } |
There was a problem hiding this comment.
We should also check this for the extra_materials code below, so you should probably factor it out into a function:
static bool has_conductivity(const material_type &md, meep::component c) {
medium_struct *mm;
if (is_medium(md, &mm) && get_cnd(c, mm)) return true;
if (md->which_subclass == material_data::MATERIAL_GRID &&
(get_cnd(c, &md->medium_1) || get_cnd(c, &md->medium_2) ||
md->damping != 0)) return true;
return false;
}and then just call this.
(And you'll also want to call it for the default_material.)
|
Could you also add documentation the PR? Just document it in the same place where |
stevengj
reviewed
Oct 28, 2021
Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
* fake conductivity term * has cond * fix * rerun check * revision & documentation * rerun check * rerun check * Update python/geom.py Co-authored-by: Steven G. Johnson <stevenj@mit.edu> Co-authored-by: Mo Chen <mochen@Mos-MacBook-Pro.local> Co-authored-by: Steven G. Johnson <stevenj@mit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1788. Fake conductivity to penalize non-binarized structure.