set the default number of threads to one for multi-threading #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Sep 1, 2021
stevengj
approved these changes
Sep 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #1745 +/- ##
==========================================
+ Coverage 73.46% 74.37% +0.90%
==========================================
Files 13 13
Lines 4557 4573 +16
==========================================
+ Hits 3348 3401 +53
+ Misses 1209 1172 -37
|
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
…p#1745) * set the default number of threads to one for multithreading * small fix in docs * refactor threads initialization into a separate setup() function * various fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the suggestion from @stevengj in #1628 (comment), this PR defines the default number of threads to one in the
fieldsclass constructor. The documentation is also updated.