tweak relative tolerance of two failing unit tests for multithreading and single precision #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and single precision
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
… and single precision (NanoComp#1742)
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
… and single precision (NanoComp#1742)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly adjusts the relative tolerance of two unit tests which are failing when compiling using multithreading (
--with-openmp) and single-precision floating point for the fields arrays (--enable-single). Unfortunately, this setup is not part of the current CI which is why these failing tests were not detected by #1628.Might be useful to add a separate test environment for multithreading and single precision but that can be done in a separate PR.