-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub workflow for CI #1596
GitHub workflow for CI #1596
Conversation
When running
|
cp $(PY_PKG_FILES) meep | ||
cp $(adjoint_PYTHON) meep/adjoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is going on with this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this change, only the $PY_PKG_FILES
were copied to the meep
folder.
In a second step, the MPB interface was added below.
However, the adjoint
subpackage was never copied to meep
.
Do you have any insight why that is the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our Python Makefile rules seem kind of hacky here; it would be better to rewrite them to cooperate with automake if possible.
Example output: https://github.com/ahoenselaar/meep/runs/2796065822 Shows a few broken tests and a segfault due to memory corruption. |
Scope:
This is intended as an initial set up step.
The failing Python tests are going to be addressed in follow-up PRs. Issues identified so far include:
verbosity_mgr
)Other improvements for follow-up PRs: