Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated features and minor tweaks to docs #1529

Merged
merged 3 commits into from
Mar 18, 2021

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Mar 14, 2021

Removes the deprecated quiet variable from the docs as well as the omega argument of several output functions including warnings that they are deprecated.

Also includes some minor tweaks to the docs.

@stevengj
Copy link
Collaborator

The omega parameter was renamed in #1131.

@stevengj
Copy link
Collaborator

quiet became redundant in #1349?

@stevengj
Copy link
Collaborator

stevengj commented Mar 17, 2021

Since it's been less than a year for quiet, maybe remove it from the documentation but keep it in the code with a deprecation warning message?

@oskooi
Copy link
Collaborator Author

oskooi commented Mar 18, 2021

The quiet function has been reinstated with a deprecation warning and its documentation has been removed from the Python User Interface page of the user manual.

@stevengj stevengj merged commit 3109c51 into NanoComp:master Mar 18, 2021
@oskooi oskooi deleted the docs_mar13 branch March 18, 2021 20:52
bencbartlett pushed a commit to bencbartlett/meep that referenced this pull request Sep 9, 2021
* remove deprecated features and minor tweaks to docs

* update docs markdown files

* reinstate quiet function and add deprecation warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants