Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjoint phase adjustments #1515

Merged
merged 9 commits into from
Mar 3, 2021
Merged

Adjoint phase adjustments #1515

merged 9 commits into from
Mar 3, 2021

Conversation

smartalecH
Copy link
Collaborator

Closes #1507 and #1471.

  • Updated the adjoint tests to include both single frequency and multi-frequency objective functions
  • Fixed some DFT fields bugs within the multi-frequency case
  • Rather than use the forward simulation's time profile, a Gaussian centered at the freq of interest is used. Interestingly, this seemed to fix the dependence of the forward simulation's pulse width (the test, for example, uses a bandwidth of 0.23*fcen).

Some caveats:

  • We still need the adj_src_phase scale factor. This factor only accounts for the center frequency of the simulation. Is it possible that an additional phase factor is being added to the source by specifying the frequency parameter? (this parameter is used to determine at what frequency the mode solver should calculate the modes -- perhaps there's an additional phase term being added here..).
  • The DFT field gradients aren't as accurate as they should be. Since we are planning to overhaul them in the same fashion as the Near2Far transform, I didn't spend much time debugging.
  • The Eigenmode sources still only calculate the eigenmode at the center frequency, which introduces some error in the gradient. For the most part, it's a small order error.

@stevengj stevengj merged commit 8606074 into NanoComp:master Mar 3, 2021
bencbartlett pushed a commit to bencbartlett/meep that referenced this pull request Sep 9, 2021
* Fix dft fields memory leak

* zero dim fix

* more cleanup

* init

* fix tests

* revert

Co-authored-by: Alec Hammond <ahammond36@gatech.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional phase factor in the adjoint simulation
2 participants