Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): feedback env settings page #3444

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

bodinsamuel
Copy link
Collaborator

@bodinsamuel bodinsamuel commented Feb 4, 2025

Changes

  • Fix page being too long
    It was due to the form tag, don't know why but solved it and could remove overflow hidden

  • Add loading to checkboxes
    There was no loading indicator and calls can sometimes be slow

  • Fix icons

  • Add link to header

@bodinsamuel bodinsamuel self-assigned this Feb 4, 2025
@bodinsamuel bodinsamuel requested a review from a team February 4, 2025 14:53
@bodinsamuel bodinsamuel enabled auto-merge (squash) February 5, 2025 09:46
@bodinsamuel bodinsamuel merged commit ac235d6 into master Feb 5, 2025
17 checks passed
@bodinsamuel bodinsamuel deleted the sam/25_02_04/fix/ui-env-settings-feedback branch February 5, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants