chore: fleet improvements #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TBonnin
commented
Feb 3, 2025
•
TBonnin
commented
- adding 'image' column to deployment
- it will make it easy to switch to another image without having to change fleet code (for example if we move runner to the unified image).
- Note: the column is not used by fleet supervisor yet. Coming in next PR :)
- checking if the image exist when rolling out to avoid rolling out while master is building
- add 'notes' column to node_overrides
- won't be used by the app but I wanted a text column where we can manually enter useful information like the name of the customer or 'Thomas's runner'
- making image, cpu_mill, memory_mb, storage_mb columns nullable in the node_overrides table. I will change the logic: if value is null, fleet will pick default values instead of having to insert specific values when overriding, especially useful for the image that changes with each deployment
TBonnin
force-pushed
the
tbonnin/NAN-2577/fleet-improvement
branch
from
6daceb9 to
93e2df3
Compare
nalanj
reviewed
Feb 4, 2025
| } | ||
| return Ok(DBDeployment.to(inserted)); | ||
| }); | ||
| } catch (err) { | ||
| return Err(new FleetError(`deployment_creation_failed`, { cause: err, context: { commitId } })); | ||
| console.log(err); |
There was a problem hiding this comment.
Not sure if this was intended or a leftover
nalanj
approved these changes
Feb 4, 2025
| previousDeployment = (await deployments.create(dbClient.db, generateCommitHash().unwrap())).unwrap(); | ||
| activeDeployment = (await deployments.create(dbClient.db, generateCommitHash().unwrap())).unwrap(); | ||
| previousDeployment = (await deployments.create(dbClient.db, generateImage().unwrap())).unwrap(); | ||
| activeDeployment = (await deployments.create(dbClient.db, generateImage().unwrap())).unwrap(); |
There was a problem hiding this comment.
.unwrap().unwrap().unwrap().unwrap() 😆
TBonnin
force-pushed
the
tbonnin/NAN-2577/fleet-improvement
branch
from
93e2df3 to
938c81d
Compare
- adding 'image' column to deployment
- it will make it easy to switch to another image without having to change
fleet code (for example if we move runner to the unified image).
- Note: the column is not used by fleet supervisor yet. Coming in next PR :)
- checking if the image exist when rolling out to avoid rolling out while master is building
- add 'notes' column to node_overrides
- won't be used by the app but I wanted a text column where we can
manually enter useful information like the name of the customer or 'Thomas's runner'
- making image, cpu_mill, memory_mb, storage_mb columns nullable in the node_overrides table.
- I will change the overiding logic: if value is null, fleet will pick default values instead of having to insert specific values when overriding, especially useful for the image that changes with each deployment
TBonnin
force-pushed
the
tbonnin/NAN-2577/fleet-improvement
branch
from
938c81d to
bd66039
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.