fix(server): /connections/:connectionId New Format #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalanj
commented
Dec 19, 2024
| onRefreshFailed: connectionRefreshFailedHook | ||
| }); | ||
| if (credentialResponse.isErr()) { | ||
| res.status(credentialResponse.error.status).send({ |
There was a problem hiding this comment.
🍖 the core of this update
There was a problem hiding this comment.
are we sure credentialResponse.error.status is always defined, if not let's || 5XX
nalanj
commented
Dec 19, 2024
packages/server/lib/controllers/connection/connectionId/getConnection.ts
Outdated
Show resolved
Hide resolved
nalanj
commented
Dec 19, 2024
TBonnin
approved these changes
Dec 19, 2024
| onRefreshFailed: connectionRefreshFailedHook | ||
| }); | ||
| if (credentialResponse.isErr()) { | ||
| res.status(credentialResponse.error.status).send({ |
There was a problem hiding this comment.
are we sure credentialResponse.error.status is always defined, if not let's || 5XX
|
@TBonnin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt to get the new /connections/:connectionId PR to land, with some updates to remove the status code changes the previous attempts included. That should help us see how much we've actually changed.