Started agrssive PEP8 reformatting, whitespace and local variable names. #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
addheaders is from the mechanize.Browers libs, you shouldn't change it. |
Nandaka
reviewed
Jan 3, 2018
| @@ -79,20 +79,20 @@ def _configureBrowser(self, config): | |||
| PixivHelper.GetLogger().info('Debug HTTP enabled.') | |||
|
|
|||
| # self.visit_response | |||
| self.addheaders = [('User-agent', config.useragent)] | |||
There was a problem hiding this comment.
should not be changed, as it is from the mechanize library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started trying to make the naming conventions in the project consistent with:
https://www.python.org/dev/peps/pep-0008/
So far I've just run over the code with pyCharm and renamed a number of local variables to use the python standard
variable_namesyntax.I haven't changed function names yet
I'm not sure whether to go with mixed case everywhere or convert to underscored lowercase. What's important is that the naming conventions are consistent in modules, and preferably consistent across PixivUtil.