Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile #1230

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Update Dockerfile #1230

merged 2 commits into from
Feb 1, 2023

Conversation

DenDen047
Copy link
Contributor

No description provided.

@Nandaka Nandaka merged commit e2db421 into Nandaka:master Feb 1, 2023
@biggestsonicfan
Copy link
Contributor

biggestsonicfan commented Feb 1, 2023 •
edited
Loading

Did you just resubmit a closed PR #1105 and #1104?

As discussed, demjson3 is already in requirements.txt and the proper docker command should be

RUN apt-get update && apt-get install -y \
     ffmpeg

or RUN apt-get update && apt-get install -y ffmpeg as there is no other dependencies to install.

This shouldn't have been accepted if it was already rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DenDen047 @biggestsonicfan @Nandaka