Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Byte Order Mark in Downloaded file list, again. #1137

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

NHOrus
Copy link
Contributor

@NHOrus NHOrus commented Jul 21, 2022

codecs.open is stateless, so simple way doesn't work and we need to deal
with state, or we get a BOM on each newline. This is suboptimal and forces
more postprocessing of Downloaded file list for correct result.

All of this code could be deleted if irfan fixes it's unicode file bug.
Alas, bug persists in all text files irfan opens, including it's config.
So fix is unlikely. :^(

Note to self: test not only on one line, but on multiple lines.

codecs.open is stateless, so simple way doesn't work and we need to deal
with state, or we get a BOM on each newline. This is suboptimal and forces
more postprocessing of Downloaded file list for correct result.

All of this code could be deleted if irfan fixes it's unicode file bug.
Alas, bug persists in all text files irfan opens, including it's config.
So fix is unlikely. :^(

Note to self: test not only on one line, but on multiple lines.
@Nandaka Nandaka merged commit c1992f9 into Nandaka:master Jul 22, 2022
@Nandaka
Copy link
Owner

Nandaka commented Jul 23, 2022

looks like you missed one place to replace?
image

supposed like this? else it have no effect.
image

Nandaka added a commit that referenced this pull request Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants