This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Scanning changes #953
Merged
Scanning changes #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the ADATS defaults to only scanning assemblies with a reference to a Nancy assemly (and nancy itself), and the autoregister ignore list is the same as it used to be.
Now instead of loading every module it can (which is significantly more than before), it will only use specified modules unless AllDiscoveredModules is set, in which case it will revert to the old behaviour.
Added new methods to ADATS for easily adding assemblies to scan.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the ADATS defaults to only scanning assemblies with a reference to a Nancy assembly (and nancy itself), and the autoregister ignore list is the same as it used to be. Adding additional assemblies to scan is now easier with the addition of the AddAssembliesToScan methods on the ADATS.
Still need to rework the InternalConfiguration to make the type scanning lazy (it's currently done even if you override everything).
Still not 100% sure the AR logic is "correct" (we could be stricter), but would need TinyIoC changes to implement anything better. We could bring it into Nancy and not use AR at all, but I think there are times where you want AR to look at assemblies that you don't want ADATS to (for instance an ISession in a database library - you'll want AR to see that to grab implementations, but you don't want to scan that assembly for configuration types and/or resources)
Also changed the Browser/Configurable bootstrapper default behaviour so it doesn't load all found modules by default, only ones that are specified - added an AllDiscoveredModules option to the configurator to change this behaviour back.