This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
NancyContext available everywhere #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first step in the "Context Everywhere" update and will make it possible for us to access the context from inside views
Also upadated the DefaultViewResolver so that is calls the current IViewLocator with the context of the current request
Added a second parameter to the Match method and updated the DefaultRouteResolver to call the matcher with the context
Also updated the DefaultRoutePatternMatcher so it passes in the correct context to the result. Also updated the FakeRoutePatternMatchResult type to have the new property.
It's now possible to set the Context property, of the fake pattern match response, using the configurator.
The IErrorHandler.HandelsStatusCode method is now passed the current NancyContext instance when being invoked. Also updated the XML comment of the function + implementations
The model binder adapter will not pass in the NancyContext, of the current request, into the IModelBinderLocator instances.
The engine and renderContext fields on HtmlHelper<TModel> were set to public. Big boo boo =)
Just a few random bits and bobs
| } | ||
|
|
||
| [Fact] | ||
| public void Should_return_match_result_with_context_of_current_request_when_paths_do_not_matched() |
There was a problem hiding this comment.
Should be match not matched :)
grumpydev
added a commit
that referenced
this pull request
Mar 14, 2012
NancyContext available everywhere
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #550
Also fixes #514 and is the pre-requisite for #483