This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Basic auth for api #349
Merged
Basic auth for api #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder whether this would be improved by making the property an enum with the values:
The latter potentially being the default (we already "detect" ajax requests for forms auth to remove the redirect). |
|
I think that is a good idea. I approached the problem only from the AJAX perspective as that is the only part of my site that is using the authentication, but if you were mixing AJAX and regular pages, then you would probably want this level of flexibility. |
added 3 commits
October 25, 2011 20:11
…at tells the browser to prompt the user for credentials. This is a poor user experience for an ajax request.
…ool to an enum with three option. Always, Never, NonAjax. NonAjax allows for regular requests to respond with the challenge HTTP header while AJAX responses will not. In this commit, NonAjax is the default, which is a change in behaviour from the current build. To replicate current behaviour, use Always.
|
New commit that encapsulates this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to the Basic Authentication plugin to stop it sending back the WWW-Authenticate header which prompts the browser to pop up a login dialog.
This popup is no good for ajax requests to a REST API.
Second commit reformats the class as it was indented with tabs instead of the spaces I saw through the rest of the project. I have done this as a seperate commit to help isolate the real changes to the file in the first commit. Hope that helps.