This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Pass NancyContext to DataAnnotationValidation Adapters #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khellang
added a commit
that referenced
this pull request
Nov 5, 2014
Pass NancyContext to DataAnnotationValidation Adapters
|
Doing some coding while at the summit? Love it! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Data Annotation Validator Adapters have no way of accessing the NancyContext.
DataAnnotationsValidatorhas access to the context, but drops it on the floor rather than passing it on toIPropertyValidator(and ultimately onto the Adapters).This PR extends the
Validatemethod onIPropertyValidatorand subsequent adapters to also acceptNancyContext, passing the context down from the core objects and making it accessible for custom validation implementations.Because of the changes to the base Data Annotation Validation interfaces, this is a breaking change.
Locally, all tests pass.