Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Diagnostics should be wired in after IApplicationStartup #692

Closed
grumpydev opened this issue Aug 7, 2012 · 3 comments
Closed

Diagnostics should be wired in after IApplicationStartup #692

grumpydev opened this issue Aug 7, 2012 · 3 comments

Comments

@grumpydev
Copy link
Member

Currently diagnostics is an IApplicationStartup and resolves several Nancy types in the process, which makes it impossible to create an IApplicationStartup that registers a decorator for one of those types.

Remove the diagnostics IApplicationStartup and resolve the DiagnosticsStartup from internal configuration (?) and execute the initialise on it after the other startup tasks have run.

@thecodejunkie
Copy link
Member

Note: The other bootstrapper now need to implement the new abstract Diagnostics method in the NancyBootstrapperBase before we can close this issue

@grumpydev
Copy link
Member Author

Oh you're such a nag ;-)

-----Original Message-----
From: Andreas Håkansson
Sent: 10/08/2012 21:08
To: NancyFx/Nancy
Cc: Steven Robbins
Subject: Re: [Nancy] Diagnostics should be wired in after IApplicationStartup (#692)

Note: The other bootstrapper now need to implement the new abstract Diagnostics method in the NancyBootstrapperBase before we can close this issue


Reply to this email directly or view it on GitHub.

@thecodejunkie
Copy link
Member

Bootstrappers all updated to include this change

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants