Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting constants #3232

Merged
merged 4 commits into from
Apr 22, 2023
Merged

Setting constants #3232

merged 4 commits into from
Apr 22, 2023

Conversation

Derkades
Copy link
Member

Suggested in this comment: #3225 (comment)

I wonder what it would be like to create some sort of Settings class which houses the get/set methods as well as constants for common settings, in a different PR of course?

Let me know what you think of this approach before I convert everything. It is fully backwards compatible with existing code. While the old Util::setSetting and Util::getSetting functions have been deprecated, I see no point in removing them. It will only break modules without a benefit.

@Derkades Derkades added this to the 2.1.0 milestone Jan 28, 2023
@samerton samerton merged commit 691a722 into develop Apr 22, 2023
@samerton samerton deleted the setting-constants branch April 22, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants