French and German translation from original games #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a root CMakeLists.txt to display all data in the C editor
Added D_GNU_SOURCE=1 to CMakeList.txt to avoid crash
Also fixed potential unitialized variable "save_path"
Message from GCC below :
warning: the comparison will always evaluate as ‘true’ for the address
of ‘save_path’ will never be NULL [-Waddress]
2387 | if (save_path != NULL && save_path[0] != '\0') {
note:
‘save_path’ declared here
2378 | char save_path[POP_MAX_PATH];
Very unlikely to overflow, but fixes the warning
GCC warning below :
warning: ‘snprintf’ output may be truncated before the last format
character [-Wformat-truncation=]
746 | snprintf(time_text, sizeof(time_text), "%d:
%02d", minutes, seconds);
‘snprintf’ output between 5 and 13 bytes into a destination of size 12
746 | snprintf(time_text, sizeof(time_text), "%d:
%02d", minutes, seconds);
types.h : missing definition of POP_MAX_PATH proto.h : missing header guard proto.h : missing several definition (added #include "common.h")
This commit adds the texts from the official German and French release. The translation concerns : - Texts at the beginning and the end of the game - In game texts (usually displayed at the bottom of the screen). A parameter has been added to SDLPoP.ini to select language. It sets a global variable "pop_language". Images were added : - in TITLE (Texts at the beginnig anf at the end of the game). - in fonts (additional characters required for French and German texts) A directory dedicated to translation was added : - legacy_ingame_texts : contains English, German and French texts - non_ascii_code : function to deal with additional characters in fonts directory (non ascii) Other changes : - The box used for bottom texts was enlarged to display the longest German text "KNOPFDRUCK ZUM WEITERSPIELEN"
Added transparency to French and German translation images used for introduction and ending (in the TITLE directory) for constitency with English version
|
Paging: #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some changes to the code to support French and German texts along with English ones.
I used original translation from the games officially released in French and German. As such the text which is specific to SDLPoP is not translated.
I also made some minor changes to fix some GCC warning, and to use cmake under Linux.