-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function for fetching ICE servers from service handlers #717
base: master
Are you sure you want to change the base?
Conversation
Look at existing tests for how to write tests. |
tests/test_ice_servers.py
Outdated
async def register_ice_servers(ice_servers: list[RTCIceServer]): | ||
nonlocal times_register_called_successfully | ||
|
||
# There asserts will silently fail and variable will not be incremented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why will they silently fail? Typo for there -> these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a callback, the test runner does not detect it failing in error logs; it just stops the further execution of the test. This could be due to try/catch in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, that's just normal test behavior when using assert. I'd not add a comment about that. It's confusing to me.
No description provided.