Add function for fetching ICE servers from service handlers #717
+271
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
approved these changes
Oct 22, 2024
|
Look at existing tests for how to write tests. |
tests/test_ice_servers.py
Outdated
| async def register_ice_servers(ice_servers: list[RTCIceServer]): | ||
| nonlocal times_register_called_successfully | ||
|
|
||
| # There asserts will silently fail and variable will not be incremented |
There was a problem hiding this comment.
Why will they silently fail? Typo for there -> these.
There was a problem hiding this comment.
As this is a callback, the test runner does not detect it failing in error logs; it just stops the further execution of the test. This could be due to try/catch in the code.
There was a problem hiding this comment.
Right, that's just normal test behavior when using assert. I'd not add a comment about that. It's confusing to me.
MartinHjelmare
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.