Add 5 min heartbeat to the CloudIoT WebSocket connection #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
approved these changes
Feb 29, 2024
|
I only tested this with the primary connection. As this is in the base it can have other side effects, moving it to draft until I'm done checking the others. |
ludeeus
commented
Mar 1, 2024
| @@ -75,6 +75,11 @@ def package_name(self) -> str: | |||
| """Return package name for logging.""" | |||
| raise NotImplementedError | |||
|
|
|||
| @property | |||
| def ws_heartbeat(self) -> float | None: | |||
There was a problem hiding this comment.
Only the CloudIoT class can use this for now, so made it a property (like ws_server_url) to allow those who inherit this base class to override it, with a default to None (current behavior).
ludeeus
changed the title
MartinHjelmare
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases (where we have a healthy connection), this will never hit because of the socket pings (which will reset this).
This is just here to mitigate problems where the instance has not received any messages in > 5 minutes.
If this is invoked, the reconnection logic will trigger.