Add pypa/gh-action-pypi-publish for publishing #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
approved these changes
Feb 29, 2024
.github/workflows/pythonpublish.yml
Outdated
| path: "dist/" | ||
|
|
||
| - name: "Publish dists to PyPI" | ||
| uses: "pypa/gh-action-pypi-publish@e53eb8b103ffcb59469888563dc324e3c8ba6f06" # v1.8.12 |
There was a problem hiding this comment.
Is the commit pin a security measure?
There was a problem hiding this comment.
Yes, this is the action that is responsible for generating a token, and uploading the files to pypi.
Tags/releases can be replaced, commits can not.
MartinHjelmare
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unsure if these permissions are too restrictive, so Ill leave this PR in draft until I have verified that.Did a simple test here, and it seems to be just fine: