Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite parse_date util to not rely on strptime #522

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Rewrite parse_date util to not rely on strptime #522

merged 2 commits into from
Oct 24, 2023

Conversation

ludeeus
Copy link
Contributor

@ludeeus ludeeus commented Oct 19, 2023 •
edited
Loading

strptime relies on the locale pacakge, which can easily be changed to invalid values by integrations like this https://github.com/BenPru/luxtronik/blob/576736e5c92cbce5f47d3523766f821e706bde8f/custom_components/luxtronik/base.py#L91.
Which makes our handling of dates invalid.

This PR switches the logic to use ciso8601.parse_datetime instead as this does not rely on strptime and the set locale.

ludeeus
ludeeus commented Oct 19, 2023
View reviewed changes
hass_nabucasa/utils.py Outdated Show resolved Hide resolved
@ludeeus ludeeus requested a review from pvizeli October 19, 2023 07:38
MartinHjelmare
MartinHjelmare approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@MartinHjelmare MartinHjelmare left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core will also have issues for this case in util.dt.parse_date. Wonder if core should patch locale.setlocale if there's no valid use case?

@ludeeus ludeeus merged commit fb0d640 into master Oct 24, 2023
2 checks passed
@ludeeus ludeeus deleted the no_strptime branch October 24, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@pvizeli pvizeli Awaiting requested review from pvizeli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludeeus @MartinHjelmare