This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 757
Update for cub::FutureValue
PR (NVIDIA/cub#305)
#1519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
zasdfgbnm
changed the title
Update for cub change cub/pull/305
Update for cub change NVIDIA/cub#305
Sep 7, 2021
zasdfgbnm
force-pushed
the
device-scan-future
branch
from
October 6, 2021 21:53
e446214
to
1ce950e
Compare
alliepiper
force-pushed
the
device-scan-future
branch
from
October 8, 2021 17:42
1ce950e
to
d21ee55
Compare
My last push just updated the CUB submodule so gpuCI can pick it up. DVS CL: 30512893 run tests |
zasdfgbnm
force-pushed
the
device-scan-future
branch
3 times, most recently
from
October 12, 2021 05:45
e1d0681
to
600e57e
Compare
@allisonvacanti The compilation failures should be fixed now. |
alliepiper
added
P1: should have
Necessary, but not critical.
helps: pytorch
Helps or needed by PyTorch.
and removed
testing: gpuCI in progress
Started gpuCI testing.
labels
Oct 14, 2021
DVS CL: 30535270 run tests |
alliepiper
added
testing: gpuCI in progress
Started gpuCI testing.
testing: internal ci in progress
Currently testing on internal NVIDIA CI (DVS).
labels
Oct 14, 2021
alliepiper
changed the title
Update for cub change NVIDIA/cub#305
Update for Oct 14, 2021
cub::FutureValue
PR (NVIDIA/cub#305)
Seems unrelated |
alliepiper
added
testing: gpuCI passed
Passed gpuCI testing.
and removed
testing: internal ci in progress
Currently testing on internal NVIDIA CI (DVS).
testing: gpuCI in progress
Started gpuCI testing.
labels
Oct 15, 2021
alliepiper
added
the
testing: internal ci passed
Passed internal NVIDIA CI (DVS).
label
Oct 15, 2021
@zasdfgbnm Yeah, that's a known compiler bug in gcc 10, it can be ignored. Internal testing on DVS also looks clean, so this is ready to go in -- thanks for advocating for this and doing the work, I really like how this feature turned out! 😀 I'll get this merged in a moment. |
alliepiper
approved these changes
Oct 15, 2021
alliepiper
force-pushed
the
device-scan-future
branch
from
October 15, 2021 16:23
600e57e
to
56aa510
Compare
alliepiper
force-pushed
the
device-scan-future
branch
from
October 15, 2021 16:28
56aa510
to
1daa53e
Compare
Last couple of pushes just updated the CUB submodule. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
helps: pytorch
Helps or needed by PyTorch.
P1: should have
Necessary, but not critical.
testing: gpuCI passed
Passed gpuCI testing.
testing: internal ci passed
Passed internal NVIDIA CI (DVS).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review NVIDIA/cub#305