Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Do not use upper cased variables #391

Closed
pavanky opened this issue Aug 15, 2013 · 0 comments · Fixed by #415
Closed

Do not use upper cased variables #391

pavanky opened this issue Aug 15, 2013 · 0 comments · Fixed by #415
Labels
type: enhancement New feature or request.

Comments

@pavanky
Copy link

pavanky commented Aug 15, 2013

Considering that thrust is an upstream project for many others, using cased names, especially when they are generic, should be avoided.

For example the following link uses the variable SMEM which is an example of something that is likely to be used as a macro.

https://github.com/thrust/thrust/blob/master/thrust/system/cuda/detail/reduce_by_key.inl

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant