Disabling the cuDF default pinned pool for 24.06 #10815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abellina
added
the
cudf_dependency
|
build |
1 similar comment
|
build |
jlowe
approved these changes
May 21, 2024
Signed-off-by: Alessandro Bellina <abellina@nvidia.com>
abellina
force-pushed
the
disable_default_pinned_pool
branch
from
eec462e
to
5899c89
Compare
|
I tried pulling 24.06 into this but I had issues trying to fast forward there, so I ended up rebasing it (it's just 1 commit so I figured that would be OK). |
|
build |
|
I am going to handle this directly in cuDF JNI by rapidsai/cudf#15815. Please see that PR for more info. I am likely to put up a documentation PR to document how the pinned pool works with different configs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10814
Depends on: rapidsai/cudf#15665 and rapidsai/cudf#15745
This PR disables a default pinned pool in cuDF since we already have one configured that is shared with cuDF and is also accessible for
HostMemoryBufferoperations.