-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate log files for Python Profiling cli #1366
Conversation
Signed-off-by: Niranjan Artal <nartal@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that no change on the scala side. I remember the log file was created by the QualificationOutputWriter
. If that's the case, it means that we cannot generate log file by simply running profiling jar cmd. Or do I miss something?
We can generate log file by providing the log4jc configuration in java command. Since the sample log4j.properties is checked in, we can modify the output file path, output file name and other parameters before running the java command.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nartal1. Tested this. LGTME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nartal1 !
LGTME
This fixes #1363
In PR-#1269, support was added to generate stderr log files for qualification tool and missed profiling tool. This PR adds support to generate log files for profiling tool as well. While doing so, refactor was done to distinguish between profiling and qualification log.
Before this change:
After this change:
New file created
rapids_4_spark_profile_stderr.log
underrapids_4_spark_profile/
directory