Isolate dataset for qualx plugin invocations #1361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isolates the rows for the targeted dataset when invoking a qualx dataset-specific plugin.
Previously, all plugins were invoked with the entire input dataframe, which relied on the plugin implementation to correctly target only the rows of its intended dataset. While this design was simple and allowed for the full flexibility to modify the data in any way, it also can lead to unexpected behavior if a plugin accidentally targets the rows of other datasets.
I have confirmed that the full workflow of preprocessing, training, and evaluate produces the same models and evaluation results.
Changes
Test
Following CMDs have been tested:
Internal Usage: