Move row conversion code from cudf #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 763406c. # Conflicts: # src/main/cpp/benchmarks/row_conversion.cpp # src/main/cpp/src/bloom_filter.cu # src/main/cpp/src/map_utils.cu # src/main/cpp/src/xxhash64.cu # thirdparty/cudf Signed-off-by: Nghia Truong <nghiat@nvidia.com>
|
build |
jlowe
reviewed
Mar 6, 2024
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
Signed-off-by: Nghia Truong <nghiat@nvidia.com>
|
build |
jlowe
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves back the row conversion code from cudf, which was moved there by rapidsai/cudf#14664 to temporarily workaround the issue due to conflict of kernel names that causes invalid memory access when calling to
thrust::in(ex)clusive_scan(#1567).Now we have fixes for the namespace visibility issue (by marking all libcudf kenels private in rapidsai/rapids-cmake#523 and NVIDIA/cuCollections#422) and need to move back the code.