This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhemstad
reviewed
May 31, 2023
jrhemstad
reviewed
May 31, 2023
jrhemstad
reviewed
May 31, 2023
include/cuda/std/detail/libcxx/include/__iterator/iterator_traits.h
Outdated
Show resolved
Hide resolved
jrhemstad
reviewed
May 31, 2023
// Just so we can migrate to the new macros gradually. | ||
|
||
#ifdef __cuda_std__ | ||
# define _LIBCUDACXX_EXECUTION_SPACE_SPECIFIER __host__ __device__ | ||
# define _LIBCUDACXX_INLINE_VISIBILITY _LIBCUDACXX_EXECUTION_SPACE_SPECIFIER | ||
# define _LIBCUDACXX_INLINE_VISIBILITY _LIBCUDACXX_HOST_DEVICE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should figure out what we're going to do with _LIBUCDACXX_INLINE_VISIBILITY/_LIBCUDACXX_HIDE_FROM_ABI/_LIBCUDACXX_HOST_DEVICE
and decide what we are going to use where and when.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The precedent from upstream is to only ever use _LIBCUDACXX_HIDE_FROM_ABI
so I think that should be the route to go
jrhemstad
approved these changes
May 31, 2023
wmaxey
approved these changes
May 31, 2023
…inst include order issues
Neither `__fp16` and `_Float16` are used internally but may potentially clash with outside definitions. Do not define what we do not use
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we define certain external macros that are used in product code.
However, this might clash with external definitions and create include order issues.
To alleviate this, define internal
_LIBCUDACXX_MEOW
macros that cannot clash with the outside world.We also defined either
__float16
or_Float16
despite them not being used internally at all. We should not do this and this has lead to compile issues on at least GCC. So drop those definitions.Addresses nvbug4139266 and nvbug4123393
Fixes #460