Add a demo creation tool and an end-to-end demo #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanchen8911
changed the title
yuanchen8911
changed the title
dmitsh
reviewed
May 8, 2024
|
|
||
| # Add virtual nodes to the cluster | ||
| helm install virtual-nodes charts/virtual-nodes -f charts/virtual-nodes/values.yaml | ||
|
|
There was a problem hiding this comment.
Can add "kubectl get node" after virtual nodes are installed, so we can show them?
There was a problem hiding this comment.
I've added it.
There was a problem hiding this comment.
I've add the demo to README too. Take a look please. https://github.com/NVIDIA/knavigator/blob/db654569d08dc1f869b090a41a7755e053c628d7/README.md
There was a problem hiding this comment.
BTW, I've created a similar demo for the DRA project too. https://github.com/NVIDIA/k8s-dra-driver
Signed-off-by: Yuan Chen <yuanc@nvidia.com> Add link to the demo svg file in README Signed-off-by: Yuan Chen <yuanc@nvidia.com> udpate demo
dmitsh
approved these changes
May 8, 2024
|
Sorry for deleting your comment by mistake. I've replaced |
dmitsh
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a demo creation tool and creates a demo that shows an end-to-end demo about how to install, configure and run
Knavigator.To generate a demo, just run
make demos/basic.svg