Extract GOLANG_VERSION from versions.mk #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
vendor-in-container
branch
from
840a3f2 to
2dbf357
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
ArangoGutierrez
added
maintenance
elezar
removed
the
testing
ArangoGutierrez
approved these changes
Feb 27, 2024
NFD includes these changes, so that's probably better. |
elezar
commented
Feb 27, 2024
| - name: Install Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: 'go.mod' | ||
| go-version: ${{ env.GOLANG_VERSION }} |
There was a problem hiding this comment.
@ArangoGutierrez we should probably look at how we can reuse something like this.
There was a problem hiding this comment.
for all other projects, yup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the golang actions to use the GOLANG_VERSION defined in versions.mk
This ensures consistency between what is built for the images and what is tested in CI.
It also adds a
vendorandcheck-vendormake target to ensure that the local go module files are up to date.