Skip to content

Commit

Permalink
Release notes for cudnn-frontend 1.5.1: (#84)
Browse files Browse the repository at this point in the history
[Bug fix] Fixed an issue, where cudnn-frontend (1.5.0) when built with
cudnn version 9.1.1 and below, runs into issues when run with 9.2.0 and
above.
  • Loading branch information
Anerudhan authored Jun 18, 2024
1 parent 47d800c commit aa3abd4
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
cmake_minimum_required(VERSION 3.17)

project(cudnn_frontend VERSION 1.5.0)
project(cudnn_frontend VERSION 1.5.1)

option(CUDNN_FRONTEND_SKIP_JSON_LIB "Defines whether FE should not include nlohmann/json.hpp." OFF)
option(CUDNN_FRONTEND_BUILD_SAMPLES "Defines if samples are built or not." ON)
Expand Down
2 changes: 1 addition & 1 deletion include/cudnn_frontend.h
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@

#define CUDNN_FRONTEND_MAJOR_VERSION 1
#define CUDNN_FRONTEND_MINOR_VERSION 5
#define CUDNN_FRONTEND_PATCH_VERSION 0
#define CUDNN_FRONTEND_PATCH_VERSION 1
#define CUDNN_FRONTEND_VERSION \
((CUDNN_FRONTEND_MAJOR_VERSION * 10000) + (CUDNN_FRONTEND_MINOR_VERSION * 100) + CUDNN_FRONTEND_PATCH_VERSION)

Expand Down
4 changes: 2 additions & 2 deletions include/cudnn_frontend/plans.h
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ class Execution_plan_list {
}

// workspace check for 9.2+ is already done at engine config level
if (detail::get_backend_version() < 90200) {
if (detail::get_backend_version() < 90200 || detail::get_compiled_version() < 90200) {
if (execution_plans[index]->getWorkspaceSize() > max_workspace_allowed) {
barred_indices[index] = true;
return {error_code_t::GRAPH_EXECUTION_PLAN_CREATION_FAILED,
Expand Down Expand Up @@ -427,7 +427,7 @@ class Execution_plan_list {
std::to_string(index)};
}

if (detail::get_backend_version() >= 90200) {
if (detail::get_backend_version() >= 90200 && detail::get_compiled_version() >= 90200) {
// Ignore kernels that require larger than tolerable shared memory.
int32_t shared_memory_size = INT32_MAX;
auto status = detail::get_shared_memory_size(engine_configs[index], shared_memory_size);
Expand Down
5 changes: 5 additions & 0 deletions include/cudnn_frontend_shim.h
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,11 @@ get_backend_version(void) {
#endif
}

inline constexpr size_t
get_compiled_version(void) {
return CUDNN_VERSION;
}

inline std::string
convert_version_to_str(size_t const version) {
// The multiplier for major version pre-v9 and post-v9 are different.
Expand Down
2 changes: 1 addition & 1 deletion python/cudnn/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

from .datatypes import _library_type, _is_torch_tensor

__version__ = "1.5.0"
__version__ = "1.5.1"


def _tensor(
Expand Down

0 comments on commit aa3abd4

Please sign in to comment.