This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix block radix rank for blocks with non multiple of 32 threads #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
approved these changes
Aug 31, 2022
alliepiper
approved these changes
Aug 31, 2022
| RankAlgorithm == cub::RadixRankAlgorithm::RADIX_RANK_MATCH_EARLY_COUNTS_ANY || | ||
| RankAlgorithm == cub::RadixRankAlgorithm::RADIX_RANK_MATCH_EARLY_COUNTS_ATOMIC_OR; | ||
|
|
||
| if (uses_warp_striped_arrangement) |
There was a problem hiding this comment.
CUB_IF_CONSTEXPR
(in <cub/detail/cpp_compatibility.cuh>)
There was a problem hiding this comment.
Since it's a test that's probably optimized by nvcc in any way, I don't see a reason to deteriorate readability. Is there anything I'm missing?
There was a problem hiding this comment.
I'm going to merge the PR. If there's a reason to change this, please let me know and I'll update the code in a follow up PR.
There was a problem hiding this comment.
Some compilers will issue a warning when a constant conditional is evaluated in a regular if (...). We should be using the if constexpr macros in public headers for these cases. Since this is just a test, we can fix it later if it becomes an issue.
| cub::BFEDigitExtractor<Key> extractor(0, RadixBits); | ||
| block_radix_rank(temp_storage).RankKeys(keys, ranks, extractor); | ||
|
|
||
| if (uses_warp_striped_arrangement) |
gevtushenko
force-pushed
the
fix-main/github/block_radix_rank
branch
from
4735117 to
1b19a77
Compare
gevtushenko
added a commit
to gevtushenko/thrust
that referenced
this pull request
Sep 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue by masking inactive threads in match any. The code generation hasn't changed for thread blocks with
(BlockThreads % 32) = 0.