Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Deprecate CTK<9 #553

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Deprecate CTK<9 #553

merged 2 commits into from
Aug 19, 2022

Conversation

gevtushenko
Copy link
Collaborator

@gevtushenko gevtushenko commented Aug 18, 2022 •
edited
Loading

⚠️ Deprecated CUB_USE_COOPERATIVE_GROUPS

Currently, CUB has code specializations for CTK < 9. Based of the CTK version, we provide a CUB_USE_COOPERATIVE_GROUPS macro. If the macro is absent, we disables *_sync variants of PTX instructions / intrinsics. This PR removes the macro and all associated code specializations. We don't test that and I have doubts if the following even legal for all the CUB facilities:

__device__  __forceinline__ void WARP_SYNC(unsigned int member_mask)
{
#ifdef CUB_USE_COOPERATIVE_GROUPS
    __syncwarp(member_mask);
#endif
}

@gevtushenko gevtushenko requested a review from alliepiper August 18, 2022 15:12
gevtushenko added a commit to gevtushenko/thrust that referenced this pull request Aug 18, 2022
@gevtushenko
Testing NVIDIA/cub#553
5830db3
@gevtushenko gevtushenko added the P2: nice to have Desired, but not necessary. label Aug 18, 2022
@gevtushenko gevtushenko added this to the 2.1.0 milestone Aug 18, 2022
@gevtushenko gevtushenko added the testing: gpuCI in progress Started gpuCI testing. label Aug 18, 2022
alliepiper
alliepiper approved these changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor change pointed out inline.

cub/util_arch.cuh Show resolved Hide resolved
@gevtushenko gevtushenko added the release: breaking change Include in "Breaking Changes" section of release notes. label Aug 18, 2022
@gevtushenko gevtushenko merged commit 615f546 into NVIDIA:main Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alliepiper alliepiper alliepiper approved these changes

Assignees
No one assigned
Labels
P2: nice to have Desired, but not necessary. release: breaking change Include in "Breaking Changes" section of release notes. testing: gpuCI in progress Started gpuCI testing.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gevtushenko @alliepiper