Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Deprecate debug synchronous #527

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Deprecate debug synchronous #527

merged 3 commits into from
Jul 19, 2022

Conversation

gevtushenko
Copy link
Collaborator

This PR addresses the following issue

@gevtushenko gevtushenko linked an issue Jul 15, 2022 that may be closed by this pull request
Break debug_synchronous usage #525
Closed
@gevtushenko gevtushenko added this to the 2.0.0 milestone Jul 15, 2022
@gevtushenko gevtushenko added the P0: must have Absolutely necessary. Critical issue, major blocker, etc. label Jul 15, 2022
@gevtushenko gevtushenko force-pushed the fix-main/github/deprecate_debug_synchronous branch 2 times, most recently from be78b65 to 7e66c4a Compare July 15, 2022 18:06
@gevtushenko gevtushenko added the testing: gpuCI passed Passed gpuCI testing. label Jul 16, 2022
@gevtushenko gevtushenko requested a review from alliepiper July 18, 2022 08:15
@gevtushenko gevtushenko mentioned this pull request Jul 18, 2022
Closed
alliepiper
alliepiper approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the new features and some of the usage sites. Some minor suggestions inline.

cub/device/device_adjacent_difference.cuh Show resolved Hide resolved
cub/device/dispatch/dispatch_adjacent_difference.cuh Show resolved Hide resolved
cub/util_debug.cuh Outdated Show resolved Hide resolved
cub/util_device.cuh Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
@gevtushenko gevtushenko force-pushed the fix-main/github/deprecate_debug_synchronous branch from 7e66c4a to e7a3538 Compare July 19, 2022 08:28
miscco
miscco approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a potential issue with unused arguments warnings, but I am not really sure whether we care

cub/device/dispatch/dispatch_adjacent_difference.cuh Show resolved Hide resolved
@gevtushenko gevtushenko merged commit fbad5be into NVIDIA:main Jul 19, 2022
@gevtushenko gevtushenko mentioned this pull request Jul 20, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miscco miscco miscco approved these changes

@alliepiper alliepiper alliepiper approved these changes

Assignees
No one assigned
Labels
P0: must have Absolutely necessary. Critical issue, major blocker, etc. testing: gpuCI passed Passed gpuCI testing.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Break debug_synchronous usage
3 participants
@gevtushenko @alliepiper @miscco