This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix block shuffle #311
Merged
Fix block shuffle #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also fixes this issue. |
gevtushenko
force-pushed
the
main-bug/github/cub_block_shuffle_down/264
branch
from
805fce1 to
dcf0671
Compare
alliepiper
suggested changes
May 26, 2021
gevtushenko
force-pushed
the
main-bug/github/cub_block_shuffle_down/264
branch
from
dcf0671 to
b0ab671
Compare
alliepiper
added a commit
to alliepiper/thrust
that referenced
this pull request
Jun 1, 2021
alliepiper
added
testing: internal ci in progress
|
DVS CL: 30027318 |
alliepiper
added
testing: internal ci passed
alliepiper
approved these changes
Jun 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix the issue with
BlockShuffle::Downfunction I've written tests forBlockShuffle. It turned out that it was broken because of the wrong_TempStoragetype which also led to extra shared memory usage.