Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test updates of CCCL (thrust, cub, libcudacxx) to 2.1.0. #343

Closed
wants to merge 13 commits into from
Closed

Test updates of CCCL (thrust, cub, libcudacxx) to 2.1.0. #343

wants to merge 13 commits into from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 2, 2023 •
edited
Loading

This PR updates cuCollections to support CCCL 2.1.0. Needed for rapidsai/rapids-cmake#399.

Do not merge until the rapids-cmake PR is ready for all repos.

Depends on #342.

@bdice bdice mentioned this pull request Aug 2, 2023
Closed
7 tasks
@bdice bdice changed the title Test rapids-cmake branch with CCCL updates to 2.1.0. Test updates of CCCL (thrust, cub, libcudacxx) to 2.1.0. Aug 2, 2023
@bdice
Copy link
Contributor Author

bdice commented Aug 2, 2023

I got builds passing locally. I think the next steps here are:

  • Continue refactoring all RAPIDS libraries.
    • Since no changes were needed in cuCollections itself, only tests/examples, we should not need to update the cuCollections version in the downstream PRs building RAPIDS with CCCL 2.1.0.
  • Once RAPIDS libraries are ready, merge the rapids-cmake PR.
  • Next, merge this PR. The rapids-cmake pinning to cuCollections can be updated if desired.
  • Then several issues that require CCCL 2.1.0 will be unblocked.

@PointKernel PointKernel added the type: feature request New feature request label Aug 2, 2023
@bdice bdice mentioned this pull request Aug 22, 2023
Merged
sleeepyjack pushed a commit that referenced this pull request Aug 22, 2023
@bdice
Use thrust::identity. (#357)
70a21da 
This PR adapts a few device lambdas to use `thrust::identity`. This
helps lift out a bit of the diff from #343.
@AustinSchuh AustinSchuh mentioned this pull request Nov 17, 2023
Merged
@PointKernel PointKernel mentioned this pull request Nov 20, 2023
Merged
@bdice
Copy link
Contributor Author

bdice commented Dec 7, 2023

Closing in favor of #404.

@bdice bdice closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel left review comments

@sleeepyjack sleeepyjack Awaiting requested review from sleeepyjack sleeepyjack will be requested when the pull request is marked ready for review sleeepyjack is a code owner

Assignees
No one assigned
Labels
type: feature request New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @PointKernel