Fix bug in the construct_at optimization #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
requested review from
wmaxey and
elstehle
and removed request for
a team
miscco
force-pushed
the
fix_construct_at_again
branch
2 times, most recently
from
a60912b
to
a6bd728
Compare
…f arithmetic types
miscco
force-pushed
the
fix_construct_at_again
branch
from
a6bd728
to
839e297
Compare
miscco
force-pushed
the
fix_construct_at_again
branch
from
88f4a38
to
7de66e8
Compare
elstehle
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at mdspan I found that our
std::construct_atoptimization also applies to narrowing conversions between arithmetic types.We need to avoid this as it is a hard error. While we are at it clean the implementation up a bit.
It was surprisingly hard to get it to work everywhere, as we are dealing with variadic packs