Refactor inline comments #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gevtushenko
requested review from
elstehle and
alliepiper
and removed request for
a team
miscco
approved these changes
Oct 19, 2023
Comment on lines
+103
to
+120
| /// The BlockLoad algorithm to use | ||
| static constexpr BlockLoadAlgorithm LOAD_ALGORITHM = _LOAD_ALGORITHM; | ||
|
|
||
| /// Cache load modifier for reading keys (and values) | ||
| static constexpr CacheLoadModifier LOAD_MODIFIER = _LOAD_MODIFIER; | ||
|
|
||
| static constexpr BlockLoadAlgorithm LOAD_ALGORITHM = _LOAD_ALGORITHM; ///< The BlockLoad algorithm to use | ||
| static constexpr CacheLoadModifier LOAD_MODIFIER = _LOAD_MODIFIER; ///< Cache load modifier for reading keys (and values) | ||
| static constexpr RadixRankAlgorithm RANK_ALGORITHM = _RANK_ALGORITHM; ///< The radix ranking algorithm to use | ||
| static constexpr BlockScanAlgorithm SCAN_ALGORITHM = _SCAN_ALGORITHM; ///< The BlockScan algorithm to use | ||
| /// The radix ranking algorithm to use | ||
| static constexpr RadixRankAlgorithm RANK_ALGORITHM = _RANK_ALGORITHM; | ||
|
|
||
| /// The BlockScan algorithm to use | ||
| static constexpr BlockScanAlgorithm SCAN_ALGORITHM = _SCAN_ALGORITHM; |
There was a problem hiding this comment.
I am not a fan of comments that are essentially respellings of the variable name.
That is the reason you just want good descriptive names
gevtushenko
force-pushed
the
enh-main/github/inline_comments
branch
from
8ddfb20
to
97dcbe1
Compare
elstehle
approved these changes
Oct 23, 2023
alliepiper
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #547
This PR is a necessary step before setting up automatic formatting.
It removes inline comments from CUB sources.
Checklist