Define compiler env vars for CMake in dev containers. #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
requested review from
jarmak-nv and
miscco
and removed request for
a team
miscco
reviewed
Oct 17, 2023
alliepiper
force-pushed
the
devcontainer-cmake-env-vars
branch
from
ba83955
to
a552b38
Compare
miscco
approved these changes
Oct 17, 2023
alliepiper
force-pushed
the
devcontainer-cmake-env-vars
branch
from
a552b38
to
7096059
Compare
gevtushenko
approved these changes
Oct 17, 2023
Strange...the presets are hardcoded to use ninja currently. I'll look into this. |
|
My bad, Ninja is used indeed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #575
Adds compilers to the devcontainer environments.