Make template parameters consistent in thrust::complex operators #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the right template parameter in thrust::complex operators w.r.t to the arguments consistently. Replace T1 with T0 in is_arithmetic<T1>.
srinivasyadav18
requested review from
ericniebler
and removed request for
a team
miscco
approved these changes
Oct 13, 2023
|
/ok to test |
1 similar comment
|
/ok to test |
|
the CI seems stuck for due to some github issue. Could you please try to restart it by pushing to the PR? Given that this PR only changes the names of template parameters I would suggest to add |
|
@miscco I have added the |
It sufficient to just add it to the commit header /ok to test |
|
/ok to test |
2 tasks
|
Thanks a lot for fixing these inconsistencies 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the right template parameter in
thrust::complexoperators w.r.t to the arguments consistently.Replaces T1 with T0 in
is_arithmetic<T1>.Description
closes #554
Checklist