Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ranges::advance #546

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Implement ranges::advance #546

merged 2 commits into from
Oct 25, 2023

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Oct 11, 2023

This is totally exciting, implementing the first CPOs

Fixes #545

@miscco miscco requested review from a team as code owners October 11, 2023 16:12
@miscco miscco requested review from griwes and ericniebler and removed request for a team October 11, 2023 16:12
@miscco miscco force-pushed the ranges_advance branch 2 times, most recently from 92dec7b to da1cbc4 Compare October 12, 2023 09:08
@miscco miscco force-pushed the ranges_advance branch 3 times, most recently from e9c700e to f17de08 Compare October 19, 2023 12:49
gevtushenko
gevtushenko approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@gevtushenko gevtushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why, but tests do not seem to be formatted using the new clang-format.

libcudacxx/include/cuda/std/detail/libcxx/include/__iterator/advance.h Outdated Show resolved Hide resolved
@miscco
Copy link
Collaborator Author

miscco commented Oct 24, 2023

The code was written before we had the new clang-format file in place and I only did a search & replace to update the headers.

I would rather not update the tests now and do it in one fell swoop once we are ready

@miscco miscco merged commit 8e89bde into NVIDIA:main Oct 25, 2023
509 checks passed
@miscco miscco deleted the ranges_advance branch October 25, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@griwes griwes griwes approved these changes

@gevtushenko gevtushenko gevtushenko approved these changes

@ericniebler ericniebler Awaiting requested review from ericniebler ericniebler is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ranges::advance
3 participants
@miscco @griwes @gevtushenko